useCachedPromise: Fix optimisticUpdate not working when paginating beyond the first page.
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxn
force-pushed
the
optimistic-update-pagination
branch
from
d57e6c3 to
728c8d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because
useCachedPromisedoesn't cache beyond the first page,optimisticUpdatealso doesn't work as expected once you paginate further. This PR:useCachedPromiseso that it only overwrites theusePromise'smutateoption if we're not paginating, or if we're on the first page.-paginatedsmoke tests to include aDelete all Items But This Oneaction, in order to testoptimisticUpdateScreencast
Before:
Screen.Recording.2024-03-15.at.16.23.53.mov
After:
Screen.Recording.2024-03-15.at.16.24.20.mov